Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Prevent spamming of settings.json #383

Open
danuo opened this issue Nov 11, 2023 · 1 comment
Open

Request: Prevent spamming of settings.json #383

danuo opened this issue Nov 11, 2023 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request Formatting Code or outputs need formatting help wanted Extra attention is needed

Comments

@danuo
Copy link

danuo commented Nov 11, 2023

This is a great working extention, but right now it is creating a settings.json with these contents in EVERY workspace folder, which feels very spammy and different to how other extentions handle things. I think the following behaviour would be better and also more standard:

  • if default settings are used, nothing should be written to any settings file
  • if non-default settings are used, these should be written to global settings file
  • only if explicitly asked for, settings should be written to workspace settings.json
@BenRogersWPG BenRogersWPG self-assigned this Nov 11, 2023
@BenRogersWPG BenRogersWPG added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed Formatting Code or outputs need formatting labels Nov 11, 2023
@BenRogersWPG
Copy link
Owner

Thank you @danuo for the request and the great detail.

I will work on researching this and fixing it!

I'll let you know if I have any questions.

Thanks again!

BenRogersWPG added a commit that referenced this issue Dec 10, 2023
### House Keeping
* Tested on VS Code 1.85 🧪
* Updated a few dependencies

### Behind The Scenes
* Continued working on Issue #383
BenRogersWPG added a commit that referenced this issue Feb 7, 2024
### House Keeping
* Tested on VS Code 1.86 🧪
* Updated a few dependencies

### Behind The Scenes
* Continued working on Issue #383
BenRogersWPG added a commit that referenced this issue Mar 1, 2024
### House Keeping
* Tested on VS Code 1.87 🧪
* Updated a few dependencies

### Behind The Scenes
* Continued working on Issue #383
BenRogersWPG added a commit that referenced this issue Apr 13, 2024
### House Keeping
* Tested on VS Code 1.88 🧪
* Updated a few dependencies

### Behind The Scenes
* Continued working on Issue #383
BenRogersWPG added a commit that referenced this issue May 4, 2024
### House Keeping
* Tested on VS Code 1.89 🧪
* Updated a few dependencies

### Behind The Scenes
* Continued working on Issue #383
BenRogersWPG added a commit that referenced this issue Jun 13, 2024
### House Keeping
* Tested on VS Code 1.90 🧪
* Updated a few dependencies

### Documentation
* Improved formatting of one section of the readme to be more consistent

### Behind The Scenes
* Continued working on Issue #383
BenRogersWPG added a commit that referenced this issue Jul 4, 2024
### House Keeping
* Tested on VS Code 1.91 🧪
* Updated a few dependencies

### Behind The Scenes
* Continued working on Issue #383
BenRogersWPG added a commit that referenced this issue Aug 3, 2024
### House Keeping
* Tested on VS Code 1.92 🧪
* Updated a few dependencies

### Behind The Scenes
* Continued working on Issue #383
* Starting work on Issue #577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Formatting Code or outputs need formatting help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

2 participants