-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Immutable dataset views for readonly morphology classes #373
base: master
Are you sure you want to change the base?
Conversation
* fixes #367 * very gross; need to use pybind11::detail to be able to touch the flags
#del points, diameters | ||
#_assert_refcount(section, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Vasculature's last section refcount is 3 instead of 1 if the points & diameters are not cleared. Very peculiar...
(morphio.Morphology, DATA_DIR / "simple-heterogeneous-neurite.swc"), | ||
(morphio.GlialCell, DATA_DIR / "astrocyte.h5"), | ||
(morphio.vasculature.Vasculature, DATA_DIR / "h5/vasculature1.h5"), | ||
(morphio.DendriticSpine, DATA_DIR / "h5/v1/simple-dendritric-spine.h5") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I forgetting something else here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks so nice! 🤩
Co-authored-by: Adrien Berchet <[email protected]>
Co-authored-by: Adrien Berchet <[email protected]>
Co-authored-by: Adrien Berchet <[email protected]>
Attempt addressing (#367 )