Immutable dataset views for readonly morphology classes #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes #367 * very gross; need to use pybind11::detail to be able to touch the flags
eleftherioszisis
commented
Feb 2, 2022
Comment on lines
+117
to
+118
| #del points, diameters | ||
| #_assert_refcount(section, 1) |
There was a problem hiding this comment.
The Vasculature's last section refcount is 3 instead of 1 if the points & diameters are not cleared. Very peculiar...
eleftherioszisis
commented
Feb 2, 2022
Comment on lines
+22
to
+25
| (morphio.Morphology, DATA_DIR / "simple-heterogeneous-neurite.swc"), | ||
| (morphio.GlialCell, DATA_DIR / "astrocyte.h5"), | ||
| (morphio.vasculature.Vasculature, DATA_DIR / "h5/vasculature1.h5"), | ||
| (morphio.DendriticSpine, DATA_DIR / "h5/v1/simple-dendritric-spine.h5") |
There was a problem hiding this comment.
Am I forgetting something else here?
Co-authored-by: Adrien Berchet <[email protected]>
Co-authored-by: Adrien Berchet <[email protected]>
Co-authored-by: Adrien Berchet <[email protected]>
eleftherioszisis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt addressing (#367 )