Implement native support for unified containers #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1uc
force-pushed
the
1uc/unified-container
branch
7 times, most recently
from
035e95d
to
4dc2b67
Compare
1uc
force-pushed
the
1uc/unified-container
branch
from
eec86f6
to
2606473
Compare
mgeplf
reviewed
May 16, 2023
|
|
||
| namespace detail { | ||
|
|
||
| // Note, that `hsize_t` might be `uint64_t` which could with `uint64_t` or |
There was a problem hiding this comment.
I should learn to write :)
| /** | ||
| * Provides the API for reading datasets from HDF5 files. | ||
| * | ||
| * The CRTP requirements are that `Derived` has a method |
There was a problem hiding this comment.
do we need to CRTP vs virtual, and rely on devirtualization? Is this a hot dispatch?
There was a problem hiding this comment.
I think we can't use virtual function calls, because of the T& out. This is usually std::vector<T>& out but the inner type differs. I don't think this goes away even if we were to switch to T read(...) const. Therefore, the only way I know to avoid a bit of code duplication is to use CRTP.
Co-authored-by: MikeG <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified HDF5 morphology containers internally concatenate the datasets across all morphologies.