Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NSETM-2279] Use shared memory to write partial DataFrames of features #33

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

GianlucaFicarelli
Copy link
Collaborator

@GianlucaFicarelli GianlucaFicarelli commented Apr 5, 2024

  • Improve performance of report extraction and features calculation by writing partial DataFrames to the shared memory (or temp directory, if shared memory is not available).
    Both the used memory and the execution time should be lower than before, when processing large DataFrames.
  • Use zstd compression instead of snappy when writing parquet files.
  • When repo is pickled, extract the DataFrames only if they aren't already stored in the cache.
  • Remove fastparquet extra dependency.

@GianlucaFicarelli GianlucaFicarelli self-assigned this Apr 5, 2024
@GianlucaFicarelli GianlucaFicarelli marked this pull request as draft April 5, 2024 15:51
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 93.70079% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 91.49%. Comparing base (5602fd3) to head (7edbf63).

Files Patch % Lines
src/blueetl/repository.py 55.55% 1 Missing and 3 partials ⚠️
src/blueetl/store/parquet.py 90.32% 0 Missing and 3 partials ⚠️
src/blueetl/store/base.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   91.47%   91.49%   +0.02%     
==========================================
  Files          45       45              
  Lines        2638     2703      +65     
  Branches      539      554      +15     
==========================================
+ Hits         2413     2473      +60     
- Misses        140      141       +1     
- Partials       85       89       +4     
Flag Coverage Δ
pytest 91.49% <93.70%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GianlucaFicarelli GianlucaFicarelli marked this pull request as ready for review April 12, 2024 13:42
@GianlucaFicarelli GianlucaFicarelli changed the title Use shared memory to write partial DataFrames of features [NSETM-2279] Use shared memory to write partial DataFrames of features Apr 19, 2024
- Improve performance of report extraction and features calculation by writing partial DataFrames to the shared memory (or temp directory, if shared memory is not available).
- Use zstd compression instead of snappy when writing parquet files.
- When repo is pickled, extract the DataFrames only if they aren't already stored in the cache.
- Remove fastparquet extra dependency.
@GianlucaFicarelli GianlucaFicarelli merged commit c2861df into main Apr 24, 2024
8 checks passed
@GianlucaFicarelli GianlucaFicarelli deleted the use_shm branch April 24, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants