[NSETM-2311] Add multi_index configuration option #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
- Coverage 91.62% 91.52% -0.11%
==========================================
Files 45 45
Lines 2628 2632 +4
Branches 535 536 +1
==========================================
+ Hits 2408 2409 +1
- Misses 137 139 +2
- Partials 83 84 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mgeplf
approved these changes
Apr 15, 2024
GianlucaFicarelli
force-pushed
the
multi_index
branch
from
b7cd430
to
b688d88
Compare
GianlucaFicarelli
changed the title
GianlucaFicarelli
force-pushed
the
multi_index
branch
2 times, most recently
from
445a81e
to
9e20c1c
Compare
Used to decide to apply reset_index() to the features dataframes
GianlucaFicarelli
force-pushed
the
multi_index
branch
from
9e20c1c
to
f42dc7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to decide to apply reset_index() to the features dataframes.
Warning: having added a new parameter in the features configuration, the features cache would be invalidated.
However, since the default value isn't changed (multi_index=True), it would be possible to migrate the cache by regenerating the analysis config in the cache, without recalculating the actual cached dataframes (to be decided if it's worth implementing a migration script).