[NSETM-2310] Allow to use the cache in readonly mode #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GianlucaFicarelli
force-pushed
the
readonly
branch
3 times, most recently
from
c9f749d
to
1e12b0b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
- Coverage 92.01% 91.62% -0.39%
==========================================
Files 45 45
Lines 2543 2628 +85
Branches 506 535 +29
==========================================
+ Hits 2340 2408 +68
- Misses 128 137 +9
- Partials 75 83 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GianlucaFicarelli
force-pushed
the
readonly
branch
2 times, most recently
from
480e122
to
e062ef7
Compare
Other: - Move the cache parameters to the dictionary ``cache`` - Add additional cache parameters
GianlucaFicarelli
force-pushed
the
readonly
branch
from
e062ef7
to
3034166
Compare
mgeplf
reviewed
Apr 22, 2024
mgeplf
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features:
cache_config.readonly, to be able to use an existing cache without exclusive locking [NSETM-2310].cache_config.store_type, to change the file format (experimental).cache_config.skip_features, to skip writing the features DataFrames (not implemented yet).Deprecations:
output, usecache_config.pathinstead.clear_cache, usecache_config.clearinstead.