Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NSETM-2312] Implement cache.skip_features, to skip writing the features DataFrames #38

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

GianlucaFicarelli
Copy link
Collaborator

No description provided.

@GianlucaFicarelli GianlucaFicarelli self-assigned this Apr 22, 2024
@GianlucaFicarelli GianlucaFicarelli marked this pull request as draft April 22, 2024 11:01
@GianlucaFicarelli GianlucaFicarelli force-pushed the skip_write_features branch 2 times, most recently from c004d93 to 08bd43b Compare April 22, 2024 11:24
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 91.47%. Comparing base (53bce0b) to head (42c3c4a).

Files Patch % Lines
src/blueetl/cache.py 70.00% 2 Missing and 1 partial ⚠️
src/blueetl/config/analysis.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   91.62%   91.47%   -0.16%     
==========================================
  Files          45       45              
  Lines        2628     2638      +10     
  Branches      535      539       +4     
==========================================
+ Hits         2408     2413       +5     
- Misses        137      140       +3     
- Partials       83       85       +2     
Flag Coverage Δ
pytest 91.47% <68.75%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GianlucaFicarelli GianlucaFicarelli marked this pull request as ready for review April 22, 2024 11:30
@GianlucaFicarelli GianlucaFicarelli changed the title Implement cache.skip_features, to skip writing the features DataFrames [NSETM-2312] Implement cache.skip_features, to skip writing the features DataFrames Apr 22, 2024
@GianlucaFicarelli GianlucaFicarelli merged commit 5602fd3 into main Apr 24, 2024
8 checks passed
@GianlucaFicarelli GianlucaFicarelli deleted the skip_write_features branch April 24, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants