-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authorization server scope changes #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be worth reaching out to OCLC to confirm it. So, in the authorization server response, there are two fields, one with 'scope' and another with 'scopes', with the same values? It's a bit clunky, but maybe that's a common mistake they observed and tried to remediate.
Yes, there are now two fields ( It seems clunky but OCLC's documentation uses "scope" and "scopes" interchangeably so I suspect it is a common mistake. I didn't add I want to create a github actions workflow to run monthly to check the responses from the Metadata API and auth server so we know if OCLC changes anything. I'll include that in a future PR though. |
Thanks, Charlotte.
That's a good idea. Let's request a new WSKey just for that purpose. GitHub provides a means to securely store credentials within the repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
OCLC Authorization server now accepts
scope
and/orscopes
as a parameter. Type and formatting ofscope
parameter is the same asscopes
.OCLC did not provide an update noting this change and their documentation on the Client Credentials Grant page uses the two parameters interchangeably.
Changed: