-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to the per-slice CSV #872
base: develop
Are you sure you want to change the base?
Conversation
2e2ae51
to
ccc2def
Compare
ccc2def
to
4445a3c
Compare
5afe50b
to
eb4c928
Compare
if (!isNullOrBlank(sliceId)) { | ||
// Only silces print the slice information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Only silces print the slice information | |
// Only slices print the slice information |
Testing
I don't see any tabulate by batch files currently in tests and I think we should include at least one. I tried to do this by using the contest that had already changed (Minneapolis Mayor 2013), turning on "Tabulate by Batch", and set the However, when running the tabulation with ![]() I changed I think we need to check one batch slice file in. What I did here seems kind of clunky. We could use the smaller contest I made to test tabulate by batch earlier Other than adding in at least one batch summary the changes LGTM! Ready for a live code review! |
Closes #871. Makes several changes as outlined there.