fix some math on the per-slice inactive ballots #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
confirmed with testing that the inactive buckets are now being reported correctly in the by slice summary files |
yezr
reviewed
Aug 15, 2024
...ots/rcv/test_data/minneapolis_multi_seat_threshold/minneapolis_multi_seat_threshold_cvr.xlsx
Outdated
Show resolved
Hide resolved
..._minneapolis_mayor/2013_minneapolis_mayor_expected_MINNEAPOLIS_W-1_P-01_precinct_summary.csv
Show resolved
Hide resolved
yezr
reviewed
Aug 23, 2024
...minneapolis_mayor/2017_minneapolis_mayor_expected_MINNEAPOLIS_W-13_P-13_precinct_summary.csv
Show resolved
Hide resolved
yezr
approved these changes
Sep 3, 2024
artoonie
added a commit
that referenced
this pull request
Sep 3, 2024
…undervotes (#857) * Split undervote bucket into "0 rankings" and "less than max rankings" * Update language choices * reintroduce zero lines * Each CVR must keep track of whether it's been fully ranked or not * don't separate exhausted (fully) and (partially) -- solve just #780 * clean up * keep order the same to minimize diff * PR review * support overvote/undervotes in Uses All Rankings * fix some math on the per-slice inactive ballots (#875) * fix some math on the per-slice inactive ballots * add test for residual surplus in by-slice * don't fix the residual surplus by-slice as its never shown * lint * clean up * remove unnecessary comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #870
In the first commit, I fix a bug where the residual surplus is not calculated for by-slice structures. However, it added a lot of complexity for no benefit: the residual surplus is not printed in by-slice files. I have removed it, but in its place, I have updated a test for by-slice tabulation on multi-winner elections which we didn't have before. That will ensure that we'll have a test to ensure that residual surplus continues to not be included in the output by-slice files.
Also fixes a GUI bug where you couldn't close the tabulation window if an exception was thrown (should really be a separate PR, but it's small...)