Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSP22 Permit #109

Merged
merged 23 commits into from
Aug 30, 2023
Merged

PSP22 Permit #109

merged 23 commits into from
Aug 30, 2023

Conversation

varex83
Copy link
Contributor

@varex83 varex83 commented Jul 13, 2023 •
edited by Artemka374
Loading

  • Traits
    • Events
    • PSP22PermitRef / PSP22Permit
    • Internal, InternalImpl
    • PSP22Permit, PSP22PermitImpl
    • Add attribute to #[openbrush::implementation] macro
  • Logic
    • Permit function
  • Tests
    • Integration
    • E2E
  • Docs
    • Web docs
    • Code docs

Base automatically changed from feature/stable-rust to develop July 18, 2023 10:17
@varex83 varex83 changed the title PSP22 Permit [WIP] PSP22 Permit Jul 19, 2023
@deuszx
Copy link

deuszx commented Jul 19, 2023

Why not go with Permit2?

@varex83 varex83 marked this pull request as draft July 19, 2023 12:56
@deepsea514
Copy link

How to generate signature for permit in TypeScript using polkadot-js api?

@deepsea514
Copy link

deepsea514 commented Aug 14, 2023 •
edited
Loading

Who is working with this issue?

@Artemka374 Artemka374 self-assigned this Aug 23, 2023
@github-actions
Copy link

Contract Name main feature/psp22-permit Difference
contract_v1 10769 10832 63
contract_v2 12451 12471 20
diamond_caller 5529 5579 50
lending_contract 41586 41421 -165
loan_contract 19803 19796 -7
my_diamond 12483 12483 0
my_proxy 4240 4240 0
my_psp22_facet_v1 9470 9533 63
my_psp22_facet_v2 9136 9190 54
my_psp22_metadata_facet 5032 5187 155
my_psp22_metadata_upgradeable 13468 13498 30
my_psp22_upgradeable 10419 10474 55
shares_contract 13542 13560 18
stable_coin_contract 11333 11414 81

@Artemka374 Artemka374 changed the title [WIP] PSP22 Permit PSP22 Permit Aug 28, 2023
@Artemka374 Artemka374 marked this pull request as ready for review August 28, 2023 14:11
@Artemka374 Artemka374 merged commit b8fc8a0 into develop Aug 30, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artemka374 Artemka374 Artemka374 approved these changes

Assignees

@Artemka374 Artemka374

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@varex83 @deuszx @deepsea514 @Artemka374 @prxgr4mm3r