Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Autoarmor & created recode branch #161

Closed
wants to merge 3 commits into from
Closed

Updated Autoarmor & created recode branch #161

wants to merge 3 commits into from

Conversation

derech1e
Copy link
Contributor

  • updated ModuleCategory
  • added startDelay
  • added dropOld option
  • added Item Damage comparision
  • added TestCase-Module to check if Autoarmor works (only dev build)

- updated ModuleCategory
- added startDelay
- added dropOld option
- added Item Damage comparision to compare
- added TestCase module to Test if Autoarmor works (only dev build)
@yorik100
Copy link

Still doesn't fix the major AutoArmor bug that makes it stuck CCBlueX/Old-LiquidBounce-Issues#3909
Could be easily fixed if AutoArmor was dropping the armor instead of putting it off

@derech1e
Copy link
Contributor Author

Still doesn't fix the major AutoArmor bug that makes it stuck CCBlueX/LiquidBounce-Issues#3909
Could be easily fixed if AutoArmor was dropping the armor instead of putting it off

I know, it was not my intention to fix this bug. I want to push this recode forward. I also added a drop option, that can be activated manually. If you have better solutions, then create a PR in this branch and add them.

@yorik100
Copy link

Still doesn't fix the major AutoArmor bug that makes it stuck CCBlueX/LiquidBounce-Issues#3909
Could be easily fixed if AutoArmor was dropping the armor instead of putting it off

I know, it was not my intention to fix this bug. I want to push this recode forward. I also added a drop option, that can be activated manually. If you have better solutions, then create a PR in this branch and add them.

I didn't read drop old, my bad

- added some other Value (not final)
@yorik100
Copy link

Not clear at all tbh

@derech1e
Copy link
Contributor Author

Not clear at all tbh

It is WIP
Why is that so hard to understand?

@yorik100
Copy link

yorik100 commented Sep 24, 2020

Why is there armor in InventoryCleaner? Why no e at the end of "DropTyp" what's the meaning of Typ?

I realized that a whole recode is needed after all. The structure and mode of operation of the InventoryCleaner should be changed. More on the Todo comment in InventoryCleaner.kt. I'll close this PR and restart the work on the recode. Do you have any special ideas or wishes @kawaiinekololis? Is someone else already working on it? Does it make sense to replace AutoArmor and InventoryCleaner with an InventoryManager?
@derech1e
Copy link
Contributor Author

derech1e commented Sep 24, 2020

I realized that a whole recode is needed after all. The structure and mode of operation of the InventoryCleaner should be changed. More on the Todo comment in InventoryCleaner.kt. I'll close probably this PR and restart the work on the recode. Do you have any special ideas or wishes @KawaiiNekoLoli ? Is someone else already working on it? Does it make sense to replace AutoArmor and InventoryCleaner with an InventoryManager?

@Teals53
Copy link
Contributor

Teals53 commented Sep 24, 2020

image

@Teals53
Copy link
Contributor

Teals53 commented Sep 24, 2020

for about stack limits

@yorik100
Copy link

I realized that a whole recode is needed after all. The structure and mode of operation of the InventoryCleaner should be changed. More on the Todo comment in InventoryCleaner.kt. I'll close probably this PR and restart the work on the recode. Do Does it make sense to replace AutoArmor and InventoryCleaner with an InventoryManager?

No, I want to be able to use only one at a time, it'd be terrible to combine both

@1zun4secondary
Copy link
Contributor

I realized that a whole recode is needed after all. The structure and mode of operation of the InventoryCleaner should be changed. More on the Todo comment in InventoryCleaner.kt. I'll close probably this PR and restart the work on the recode. Do you have any special ideas or wishes @KawaiiNekoLoli ? Is someone else already working on it? Does it make sense to replace AutoArmor and InventoryCleaner with an InventoryManager?

No, I don't think so. But I don't like the idea of replacing AutoArmor and InventoryCleaner with a InventoryManager.

@derech1e derech1e closed this Sep 25, 2020
@Teals53
Copy link
Contributor

Teals53 commented Sep 25, 2020

but why its closed ? @derech1e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants