-
-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Autoarmor & created recode branch #161
Conversation
derech1e
commented
Sep 20, 2020
- updated ModuleCategory
- added startDelay
- added dropOld option
- added Item Damage comparision
- added TestCase-Module to check if Autoarmor works (only dev build)
- updated ModuleCategory - added startDelay - added dropOld option - added Item Damage comparision to compare - added TestCase module to Test if Autoarmor works (only dev build)
Still doesn't fix the major AutoArmor bug that makes it stuck CCBlueX/Old-LiquidBounce-Issues#3909 |
I know, it was not my intention to fix this bug. I want to push this recode forward. I also added a drop option, that can be activated manually. If you have better solutions, then create a PR in this branch and add them. |
I didn't read drop old, my bad |
- added some other Value (not final)
Not clear at all tbh |
It is WIP |
Why is there armor in InventoryCleaner? Why no e at the end of "DropTyp" what's the meaning of Typ? |
I realized that a whole recode is needed after all. The structure and mode of operation of the InventoryCleaner should be changed. More on the Todo comment in InventoryCleaner.kt. I'll close this PR and restart the work on the recode. Do you have any special ideas or wishes @kawaiinekololis? Is someone else already working on it? Does it make sense to replace AutoArmor and InventoryCleaner with an InventoryManager?
I realized that a whole recode is needed after all. The structure and mode of operation of the InventoryCleaner should be changed. More on the Todo comment in InventoryCleaner.kt. I'll close probably this PR and restart the work on the recode. Do you have any special ideas or wishes @KawaiiNekoLoli ? Is someone else already working on it? Does it make sense to replace AutoArmor and InventoryCleaner with an InventoryManager? |
for about stack limits |
No, I want to be able to use only one at a time, it'd be terrible to combine both |
No, I don't think so. But I don't like the idea of replacing AutoArmor and InventoryCleaner with a InventoryManager. |
but why its closed ? @derech1e |