Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

贡献方针大修；简化包内 README #2857

Merged
merged 60 commits into from
Aug 3, 2023
Merged

贡献方针大修；简化包内 README #2857

merged 60 commits into from
Aug 3, 2023

Conversation

mamaruo
Copy link
Member

@mamaruo mamaruo commented Jan 23, 2023 •
edited
Loading

  • 我已仔细阅读贡献指南 CONTRIBUTING； 我就是来改你的。
  • 我已阅读并同意按 CC BY-NC-SA 4.0 协议发布我的作品；
  • 刷新 PR 的标签/状态，有需要再点击；

@boring-cyborg boring-cyborg bot added 1.12.x Minecraft 版本标签 1.16.x Minecraft 版本标签 1.18.x Minecraft 版本标签 1.19.x Minecraft 版本标签 Fabric 包含 Fabric 模组 Forge 包含 Forge 模组 labels Jan 23, 2023
@cfpa-bot
Copy link
Contributor

cfpa-bot bot commented Jan 23, 2023 •
edited
Loading

ℹ 此 PR 没有检测到 CurseForge 模组修改。

💾 基于此 PR 所打包的资源包：

⚠⚠⚠ 检测到了可能不合规的路径。
⚠⚠⚠ 检测到了可能不合规的路径。
⚠⚠⚠ 检测到了可能不合规的路径。
⚠⚠⚠ 例如： .github/ISSUE_TEMPLATE/config.yml
⚠⚠⚠ 转到 这里 来查看所有不合规的路径。

🔛 Diff：

  • 🔄 勾选这个复选框来强制刷新

@cfpa-bot cfpa-bot bot added 500+ 行数标签 config PR 中的更改涉及 Config 文件夹 labels Jan 23, 2023
@mamaruo mamaruo marked this pull request as draft January 23, 2023 17:32
@cfpa-bot cfpa-bot bot added the 未完成 PR 内容尚未完成 label Jan 26, 2023
@mamaruo mamaruo mentioned this pull request Feb 8, 2023
Closed
@Ricky-fight Ricky-fight mentioned this pull request Feb 19, 2023
Closed
@mamaruo mamaruo marked this pull request as ready for review February 22, 2023 17:22
@mamaruo
Copy link
Member Author

mamaruo commented Feb 22, 2023

我已经不知道该写什么了，每次打开这个工作区就盯着发呆。

@DrIceTea123
Copy link
Contributor

DrIceTea123 commented Feb 23, 2023 •
edited
Loading

个人建议：

  1. #2715(comment)的讨论（经典永流传），以及之前群里提到过的关于Harvest、Mine和Mining的准则，可以添加到翻译用语共识；
  2. CONTRIBUTING里有一些pr或issue的编号，可以加上超链接；
  3. 包内README可以加上反馈渠道（兔小巢和GitHub issue）

暂时就想到这些，希望早点改完早点merge（）

@Cactusstudent
Copy link
Collaborator

Cactusstudent commented Feb 26, 2023 •
edited
Loading

个人建议：

  1. #2715(comment)的讨论（经典永流传），以及之前群里提到过的关于Harvest、Mine和Mining的准则，可以添加到翻译用语共识；
  2. CONTRIBUTING里有一些pr或issue的编号，可以加上超链接；
  3. 包内README可以加上反馈渠道（兔小巢和GitHub issue）

暂时就想到这些，希望早点改完早点merge（）

1.那个Harvest翻译准则其实是我就匠魂的情况单独立出来的，不具有普适性。木那个的话说不定群里讨论下可以转正
2.兔小巢那玩意看着头疼还难收集，我尽量两三周就去移一下
3.看mamaruo，但是这是一个好建议。

dovisutu
dovisutu reviewed Jul 21, 2023
View reviewed changes
CONTRIBUTING.md Show resolved Hide resolved
projects/1.16-fabric/README.md Outdated Show resolved Hide resolved
@dovisutu dovisutu mentioned this pull request Jul 22, 2023
Merged
@cfpa-bot cfpa-bot bot added 1000+ 行数标签 and removed 500+ 行数标签 labels Jul 30, 2023
Cactusstudent
Cactusstudent previously approved these changes Jul 30, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
dovisutu
dovisutu reviewed Jul 31, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Cactusstudent Cactusstudent added the 即将合并 在此标签被添加的 24 小时后 Pull Request 才可被合并 label Aug 1, 2023
@mamaruo mamaruo merged commit 650096c into main Aug 3, 2023
3 of 5 checks passed
mamaruo added a commit that referenced this pull request Aug 3, 2023
@mamaruo
Revert "贡献方针大修；简化包内 README (#2857)"
0fea2fa 
This reverts commit 650096c.
This was referenced Aug 4, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dovisutu dovisutu dovisutu left review comments

@Cactusstudent Cactusstudent Cactusstudent approved these changes

Assignees
No one assigned
Labels
1.12.x Minecraft 版本标签 1.16.x Minecraft 版本标签 1.18.x Minecraft 版本标签 1.19.x Minecraft 版本标签 1000+ 行数标签 config PR 中的更改涉及 Config 文件夹 Fabric 包含 Fabric 模组 Forge 包含 Forge 模组 即将合并 在此标签被添加的 24 小时后 Pull Request 才可被合并 需要帮助
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[其他]：CONTRIBUTING的文档长期未更新
5 participants
@mamaruo @DrIceTea123 @Cactusstudent @luoxueyasha @dovisutu