Pull request for performance analysis #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial version of performance test.
Adding a reporting listener for performance analysis.
Adding metrics into the listener.
Getting changes from develop.
Adding todo metris in the listener.
Integrating google spreadsheet writer.
Commiting the credential store.
Adding hyperlink for git commit id.
Updating the git branch url.
Changing the url to point to the respective commit in github.
Updating the ruleset parameter to accept more than one ruleset.
Getting changes from develop.
johspaeth
reviewed
Jun 13, 2019
| .build()); | ||
| setErrorsCount(new ErrorSpecification.Builder("<constants.Constants: void <clinit>()>") | ||
| .withTPs(HardCodedError.class, 1) | ||
| .build()); |
There was a problem hiding this comment.
Did you revert the lines on pupose?
Updating the changes from develop branch. Added three maven benchmark projects for performance analysis.
Removing average fields.
- Credentials for the google sheet is to be passed as maven test case argument. - Added new performance metrics - number of findings
Refreshing the token after every request.
Removing the stored token credentials.
johspaeth
requested changes
Jun 17, 2019
…namically download them before the start of analysis
Adding line number to the command line reporter.
Adding the sarif schema version being used in the reporter.
Updating the jenkins file to include new stage for performance analysis. Moving the google sheet credentials to Jenkins secret text.
Fixing the build error.
|
Hey @johspaeth & @sritejakv , Linking @AnakinSklavenwalker to take it from here. |
|
Hi @kruegers, this pull request is to run a performance test in Jenkins for each commit in CrypotAnalysis (master and develop branches). It downloads three applications from GitHub and runs CryptoAnalysis to record few metrics which are stored in a Google spreadsheet online. This might be helpful in identifying sudden performance changes after merging new features into the develop or master branches. |
# Conflicts: # CryptoAnalysis/pom.xml # CryptoAnalysis/src/main/java/crypto/reporting/CommandLineReporter.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for performance analysis