This repository has been archived by the owner on May 27, 2024. It is now read-only.
Fixes, and new features #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error was: Error in loading component property: [JFrame]->jTabbedPane1->jPanel1->mapJXMapKit->scrollableTracksViewportWidth No such property exists in the component.
Some older commits broke the possibility to update the gui in netbeans and the autogeneration of that code. This will restore it. Tested on netbeans 18
This is required so that when opening the DSC file in JOSM it is possible to send the changeset (especially when there are no modifications but only creations in the dsc)
|
|
|
I will have a look at this on the weekend. I have a private wip branch where I am working paralelling the readin peformance., I will see If can cherry pick onto this. |
…as Osm value If values are not trimmed or have duplicate spaces, jsom will warn on upload of the osc file
…and not name in OSM, 'name' tag has a specific format which is not equivalent to the route name in GTFS
Possible now that we have updated tag_defs.java
Because order is important in ptv2
…en both gtfs & osm have the same type Same type means either both are platforms, or both are stations Otherwise, we may match a GTFS station with a OSM platform/stop, or a GTFS platform/stop with an OSM station which would be wrong. This was especially a problem when the GTFS station & GTFS stop/platform are at the exact gps position.
This will avoid duplicate values, and also trim the individual values
Useful to build the route name with the name of the town for 'from' & 'to'
Sometimes there are stops which are on an abnormal location which would increase the boudingbox for the osm query, which could become too large, For example if the stop if on another continent...
|
Looks good! |
|
What do you mean by full way/relation support? Is it in addition to what's in this MR? |
Yes,- adding support for stop_area relations, and railway platforms ways,, |
Otherwise, in the reportview the osm tags are not copied to the 'new value' column
Regression appeared in e8e89ed
In some cases, town with "œ" were not considered same as when it has "oe" There were also problems where alt_names had too much values (duplicates because of accent or œ character)
|
@barbeau this can be merged when you are ready |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice if this could be merged before other PRs appear since there are many changes (in order to prevent conflicts).
The state of the code in the PR was used to submit to OSM the "Fluo Grand Est 68" bus network in France.
waysin OSM (until now, only nodes were supported)