Revert mixed precision mode #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-costa
force-pushed
the
revert-mixed-prec
branch
3 times, most recently
from
11c9e57
to
2d65561
Compare
p-costa
force-pushed
the
revert-mixed-prec
branch
from
2d65561
to
b72f66b
Compare
p-costa
added a commit
that referenced
this pull request
Oct 24, 2022
* revert mixed-precision mode * updated readme * bump 2decomp submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mixed-precision mode that was triggered when building with
SINGLE_PRECISION_POISSON=1has been removed from themainbranch.While this mode yields excellent results for many benchmarks, it resulted in a more complex code that is harder to follow for the average user. Moreover, simply performing the whole calculation in lower precision seems to do a good job for many benchmarks.
Hence, in favor of a more readable code, we removed this feature from the main branch, a decision that can be reconsidered in the future. This option can still be explored in v2.0.1, and is valuable for a few very high Reynolds numbers or other setups with extremely fine grids.
Closes #40.