Show schedules till they are completed #3236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently schedules are shown on the status page when they are in the status upcoming or in progress. But, when the scheduled time is in the past - it's hidden, even when it's still going on. This PR fixes this issue by hiding the maintenance when it's in the status completed, or the completed time has passed.
|
Congratulations on opening your first Pull Request, this is a momentous day for you and us! ✨
|
|
This makes sense. Thanks for this! |
|
Hooray! Your first Pull Request was merged, here's to many more 🚀 |
|
This PR + merge made the scheduled maintenace disappears completely, Please revert this commit or fix the problem. |
|
@thomasxd24 are you sure? We're using this in production, which seems to work as promised. Let me double check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently schedules are shown on the status page when they are in the status upcoming or in progress. But, when the scheduled time is in the past - it's hidden, even when it's still going on and regardless of the completed time entered.
This PR fixes this issue by hiding the maintenance when it's in the status completed, or the completed time has passed.