Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance window disappearing when ongoing #3548

Closed
Wouter0100 opened this issue Apr 16, 2019 · 2 comments · Fixed by #3580
Closed

Maintenance window disappearing when ongoing #3548

Wouter0100 opened this issue Apr 16, 2019 · 2 comments · Fixed by #3580
Labels

Comments

@Wouter0100
Copy link
Contributor

Last time I made a pull request (see here) to fix this behaviour, but unfortunately it was rolled back in 1fdb790 (can't find the related PR).

Regardless, 1fdb790 unfortunately breaks this issue again.

The problem: the maintenance window is shown just fine in the beginning. Although, when scheduled_at time is hit - it disappears. Honestly, this seems a bit odd - as especially when the maintenance is ongoing (so between scheduled_at and completed_at), visitors should be aware of it.

@welcome
Copy link

welcome bot commented Apr 16, 2019

👋 Thank you for opening your first issue. I'm just an automated bot that's here to help you get the information you need quicker, so please ignore this message if it doesn't apply to your issue.
If you're looking for support, you should try the Slack group by registering your email address at https://cachethq-slack.herokuapp.com. Alternatively, email [email protected] for our Professional support service (please note, this a paid service.)
If you're issue is with documentation, you can suggest edits by clicking the Suggest Edits link on any page, or open an issue at https://github.com/CachetHQ/Docs

@jimmybrancaccio
Copy link

This seem to work for me

--- Schedule.php	2019-05-08 18:19:55.716465292 -0500
+++ Schedule.php.patched	2019-05-08 18:21:18.970523919 -0500
@@ -171,7 +171,7 @@
      */
     public function scopeFutureSchedules($query)
     {
-        return $query->whereIn('status', [self::UPCOMING, self::IN_PROGRESS])->where('scheduled_at', '>=', Carbon::now());
+        return $query->whereIn('status', [self::UPCOMING, self::IN_PROGRESS])->where('scheduled_at', '<>', Carbon::now());
     }
 
     /**

I am no coder/developer by any stretch of the imagination so there's probably a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants