Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9 consider typename as metafield with 0 complexity #10

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

Checho3388
Copy link
Owner

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Fields with names equal to __typename will be considered 0 complexity fields such as MetaFields.

Related Tickets & Documents

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: Please replace this line with details on why tests
    have not been included
  • I need help with writing tests

@Checho3388 Checho3388 linked an issue Mar 14, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5fdfdd1) to head (751f3a7).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          517       523    +6     
=========================================
+ Hits           517       523    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Checho3388 Checho3388 merged commit 8aa621f into main Mar 14, 2024
5 checks passed
@Checho3388 Checho3388 deleted the 9-consider-__typename-as-metafield-with-0-complexity branch March 14, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider __typename as MetaField with 0-complexity
1 participant