Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 allow multipliers in directivesestimator #6

Merged
merged 15 commits into from
Mar 13, 2024

Conversation

Checho3388
Copy link
Owner

@Checho3388 Checho3388 commented Mar 12, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Now Complexity calculates or multiplies the complexity of List fields by the size of the field. Size is estimated by reading an argument (named by default as first) from the field.

Also, as part of the job, the Complexity nodes structure has been adapted to be a tree instead of a stack.

Related Tickets & Documents

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: Please replace this line with details on why tests
    have not been included
  • I need help with writing tests

@Checho3388 Checho3388 linked an issue Mar 12, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (372a3d7) to head (6fb43f4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main        #6      +/-   ##
===========================================
+ Coverage   99.30%   100.00%   +0.69%     
===========================================
  Files          15        20       +5     
  Lines         434       517      +83     
===========================================
+ Hits          431       517      +86     
+ Misses          3         0       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Checho3388 Checho3388 merged commit 52c7507 into main Mar 13, 2024
3 checks passed
@Checho3388 Checho3388 deleted the 3-allow-multipliers-in-directivesestimator branch March 13, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multipliers in DirectivesEstimator
1 participant