Refactor literal parser using AST instead of regex #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regex gives false-positive matchs like comments, big strings etc.
Use of
@graphql-tools/graphql-tag-pluck
for literals extract. This lib is used by@graphql-codegen
so given result is reliable and gives reduce amount of code to maintain.Since it has impact on performance, 2 first commits gives a self-made solution, more limited and less-safe but more performant. Consider revert to this solution if performance become an issue.
fix #20