Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thaumic Speedup mod probably not working #61

Closed
Krutoy242 opened this issue Feb 18, 2024 · 3 comments
Closed

Thaumic Speedup mod probably not working #61

Krutoy242 opened this issue Feb 18, 2024 · 3 comments

Comments

@Krutoy242
Copy link

Thaumcraft requre 20+ seconds to load.

Spark game loading profiler shows that method thaumcraft.common.config.ConfigAspects.postInit() took 20+ seconds to load.

https://spark.lucko.me/IUXt4qcv0A

image

As i understand correct, its aspect generation and its should be handled by mod Thaumic Speedup. On Java 8 its took 3-5 seconds or even less.

debug.log

Krutoy242 added a commit to Krutoy242/Enigmatica2Expert-Extended that referenced this issue Mar 27, 2024
Before this change, Thaumcraft for each item in game recursively iterated all its recipes to determine Aspect cost. This was caused lot of computation and took 10-30 seconds of game load.

Usually, this issue handled by `Thaumic Speedup` mod, but in some environment like Java21 its not working.

New config option will allow to disable this feature.
Side effect - most of items that doesnt have hardcoded aspects would not have aspects.

Note:
This option is harmless set to `true` if you playing on server with `false` value.

Related CleanroomMC/Cleanroom#61

https://i.imgur.com/fIRFwLz.png
@ZZZank
Copy link
Contributor

ZZZank commented May 10, 2024

Thaumic Speedup is indeed not working, due to usage of an outdated API.
Fugue 0.14.7 provides a patch for it, as a temporary solution before this mod gets updated.
Give it a try?

@Krutoy242
Copy link
Author

I will maybe try!

@Rongmario
Copy link
Member

Closing as older MixinBooter API isn't shaded in. Will update Thaumic Speedup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants