Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch_array -> on_architecture #70

Merged
merged 3 commits into from
Mar 27, 2024
Merged

arch_array -> on_architecture #70

merged 3 commits into from
Mar 27, 2024

Conversation

navidcy
Copy link
Collaborator

@navidcy navidcy commented Mar 26, 2024

arch_array was deprecated after CliMA/Oceananigans.jl#3490

Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice though I think we should deprecate NearGlobalSimulations... they shouldn't be used...

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (7afcd80) to head (2698c71).

Files Patch % Lines
...rGlobalSimulations/one_degree_global_simulation.jl 0.00% 6 Missing ⚠️
...balSimulations/quarter_degree_global_simulation.jl 0.00% 6 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #70   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         12      12           
  Lines        634     634           
=====================================
  Misses       634     634           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@navidcy navidcy merged commit 51620e0 into main Mar 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants