You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just noticed that we pass in a seed here, this should be passing around an rng::AbstractRNG so users can use more stable options than Random.seed!().
In particular we should be writing functions that take in function f(..., rng::RNG) where {RNG <: AbstractRNG}
Or have a keyword with default function f(..., rng = Random.default_rng())
and the rng should be stored in the ekp object.
This will make randomness far more traceable in our code.
The text was updated successfully, but these errors were encountered:
EnsembleKalmanProcesses.jl/src/EnsembleKalmanProcess.jl
Line 354 in 3e7494e
Just noticed that we pass in a seed here, this should be passing around an
rng::AbstractRNG
so users can use more stable options thanRandom.seed!()
.In particular we should be writing functions that take in
function f(..., rng::RNG) where {RNG <: AbstractRNG}
Or have a keyword with default
function f(..., rng = Random.default_rng())
and the
rng
should be stored in the ekp object.This will make randomness far more traceable in our code.
The text was updated successfully, but these errors were encountered: