Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License copyright text not filled out #276

Closed
JimCircadian opened this issue Apr 22, 2023 · 2 comments · Fixed by #277 or #278
Closed

License copyright text not filled out #276

JimCircadian opened this issue Apr 22, 2023 · 2 comments · Fixed by #277 or #278

Comments

@JimCircadian
Copy link

Hello

I'm deriving a workflow using my ensembler tool for HPC ensembling of the examples and noticed your license text in LICENSE is not filled out (I'm including it to acknowledge the source of the example!) If you can fill it out, I'll re-add your license for proper attribution!!! 😄

Copyright [yyyy] [name of copyright owner]
@odunbar odunbar mentioned this issue Apr 24, 2023
@odunbar
Copy link
Collaborator

odunbar commented Apr 24, 2023

Hi @JimCircadian Thanks for bringing this to our attention! I've just created a PR for this, and merge it in soon, likely with a 1.0.1 version number.

Also I'd like to thank you, both for your interest in our package, and for developing tools to aid with ensemble HPC. I think it's an often overlooked, yet important responsibility for our community to ease users into the paradigm shift towards ensemble computation! Thanks for taking this on!

@bors bors bot closed this as completed in 8aee1d9 Apr 24, 2023
@odunbar
Copy link
Collaborator

odunbar commented May 1, 2023

Addendum - Further updates from the our team indicates that we follow the procedure as here and used in e.g., ClimaCore.jl.

This has a LICENSE file copied verbatim [unfilled], and a NOTICE file with the filled details, I shall do this now!

@odunbar odunbar mentioned this issue May 1, 2023
1 task
bors bot added a commit that referenced this issue May 1, 2023
278: license r=odunbar a=odunbar

<!--- THESE LINES ARE COMMENTED -->
## Purpose 
<!--- One sentence to describe the purpose of this PR, refer to any linked issues:
#14 -- this will link to issue 14
Closes #2 -- this will automatically close issue 2 on PR merge
-->
resolves #276 

- [x] I have read and checked the items on the review checklist.


Co-authored-by: odunbar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants