Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darcy.jl: problem when plotting true flow #325

Closed
sydneyvernon opened this issue Sep 18, 2023 · 0 comments · Fixed by #326
Closed

darcy.jl: problem when plotting true flow #325

sydneyvernon opened this issue Sep 18, 2023 · 0 comments · Fixed by #326
Assignees
@odunbar

Comments

@sydneyvernon
Copy link
Contributor

In the plotting code in examples\Darcy\darcy.jl, we plot "true flow" in line 169 using variable h_2d which was mistakenly overwritten on line 155 and no longer represents the true flow.
This can be quickly fixed by either (1) re-evaluating darcy model on κ_true before plotting true flow or (2) renaming h_2d in lines 80 and 81 as h_2d_true
@odunbar odunbar self-assigned this Sep 18, 2023
@odunbar odunbar mentioned this issue Sep 18, 2023
Merged
1 task
bors bot added a commit that referenced this issue Sep 18, 2023
@bors @odunbar
Merge #326
9275cc5 
326: Bugfix darcy plot r=odunbar a=odunbar

<!--- THESE LINES ARE COMMENTED -->
## Purpose 
<!--- One sentence to describe the purpose of this PR, refer to any linked issues:
#14 -- this will link to issue 14
Closes #2 -- this will automatically close issue 2 on PR merge
-->
Closes #325 

## Content
<!---  specific tasks that are currently complete 
- Solution implemented
-->
- variable rename
- [ALSO] docs build error fixed (due to updated Documenter version) by removing `strict=true`

<!---
Review checklist

I have:
- followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/
- followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/
- followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy
- checked that this PR does not duplicate an open PR.

In the Content, I have included 
- relevant unit tests, and integration tests, 
- appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

-->

----
- [x] I have read and checked the items on the review checklist.


Co-authored-by: odunbar <[email protected]>
@bors bors bot closed this as completed in 06d68d9 Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odunbar odunbar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix darcy plot CliMA/EnsembleKalmanProcesses.jl
2 participants
@odunbar @sydneyvernon