Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize UKI constructor to be consistent with EKS, document kwargs #84

Closed
ilopezgp opened this issue Dec 8, 2021 · 1 comment
Closed
Assignees

Comments

@ilopezgp
Copy link
Contributor

ilopezgp commented Dec 8, 2021

The UKI constructor requires α_reg and update_freq as arguments that do not have a default value. It would be good to make them keyword arguments with default to make it easier for users to use an off-the-shelf version, with a similar constructor to EKS (so, just an initial mean and variance).

I think α_reg=1 by default, but what about update_freq?

In addition κ and β are not defined, and there is a TODO flag within the constructor. It would be good to clean this up.

@ilopezgp
Copy link
Contributor Author

Closed by #86 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants