Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize UKI constructor to be consistent with EKS, document kwargs #86

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

Zhengyu-Huang
Copy link
Contributor

The UKI constructor modification

function Unscented(
    u0_mean::Vector{FT},
    uu0_cov::Matrix{FT};
    α_reg::FT = 1.0,
    update_freq::IT = 1,
    modified_unscented_transform::Bool = true,
    prior_mean::Union{Vector{FT}, Nothing} = nothing,
) where {FT <: AbstractFloat, IT <: Int}

require α_reg, update_freq, modified_unscented_transform, and prior_mean as keyword arguments
clean up κ and β.

Copy link
Contributor

@ilopezgp ilopezgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zhengyu-Huang
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 10, 2021

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants