Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify interface #92

Closed
charleskawczynski opened this issue Jan 19, 2022 · 1 comment · Fixed by #98
Closed

Simplify interface #92

charleskawczynski opened this issue Jan 19, 2022 · 1 comment · Fixed by #98
Assignees

Comments

@charleskawczynski
Copy link
Member

charleskawczynski commented Jan 19, 2022

One of the nice parts of Julia is that we can extend existing methods, for example,

get_mean(d::Parameterized) = mean(d.distribution)

could simply extend the StatsBase mean method

import StatsBase
...
StatsBase.mean(d::Parameterized) = StatsBase.mean(d.distribution)

This can be applied to several methods (e.g., get_mean, len, size etc.)

@charleskawczynski charleskawczynski self-assigned this Jan 19, 2022
@ilopezgp
Copy link
Contributor

Let's go through these before release 0.2, since some of these will be breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants