Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending functions from packges #98

Merged
merged 16 commits into from
Jan 27, 2022
Merged

Extending functions from packges #98

merged 16 commits into from
Jan 27, 2022

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Jan 25, 2022 •
edited
Loading

Purpose

To replace some functions with corresponding extensions from existing packages. (and the relevant tests/examples)
resolves #92

In this PR

  • ParameterDistributions: By extending from StatsBase. Replacing get_mean get_var get_cov 'sample_distribution' by extending mean var cov sample
  • ParameterDistributions: by extending Base: Change len to length, added size, change dimensionand get_total_dimension to ndims

@odunbar odunbar changed the title Extending functions from packges [WIP] Extending functions from packges Jan 25, 2022
@ilopezgp
Copy link
Contributor

I saw a few instances of the pythonic len instead of the julian length. Let's change those as well.

@odunbar odunbar changed the title [WIP] Extending functions from packges Extending functions from packges Jan 26, 2022
@odunbar
Copy link
Collaborator Author

odunbar commented Jan 26, 2022

bors try

bors bot added a commit that referenced this pull request Jan 26, 2022
@bors
Try #98:
8572693
@odunbar odunbar requested a review from ilopezgp January 26, 2022 22:32
@bors
Copy link
Contributor

bors bot commented Jan 26, 2022

try

Build succeeded:

ilopezgp
ilopezgp reviewed Jan 26, 2022
View reviewed changes
docs/src/API/ParameterDistributions.md Show resolved Hide resolved
src/ParameterDistributions.jl Outdated Show resolved Hide resolved
src/ParameterDistributions.jl Outdated Show resolved Hide resolved
ilopezgp
ilopezgp approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@ilopezgp ilopezgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @odunbar !

src/ParameterDistributions.jl Outdated Show resolved Hide resolved
@odunbar @ilopezgp
size(,1)
f352ed6 
Co-authored-by: Ignacio Lopez-Gomez <[email protected]>
@odunbar
Copy link
Collaborator Author

odunbar commented Jan 27, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 27, 2022

Build succeeded:

@bors bors bot merged commit 17599cc into main Jan 27, 2022
@bors bors bot deleted the orad/overloading-statsbase branch January 27, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilopezgp ilopezgp ilopezgp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify interface
2 participants
@odunbar @ilopezgp