Address issue #113 #119
Address issue #113 #119
Conversation
|
Looks good! could you merge base in? Then I'm happy to have this merged in |
|
It might be a good idea to limit this PR to #113 so we can merge it quickly. I am not sure how involved the other one will be @jinlong83 . |
I agree. I saw that Convex v0.14 has about 20 releases, and v0.15.0 just came out one day ago? I'd suggest stay with v0.14.x for now if possible, and I'll play with v0.15.x to better understand the issue of #117 |
|
Thank you @jinlong83 ! Could you squash your commits before we merge? Thanks! |
jinlong83
force-pushed
the
jw/sparse_eki
branch
2 times, most recently
from
f141bfd
to
32c0105
Compare
|
bors r+ |
|
Canceled. |
119: Address issue #113 r=ilopezgp a=jinlong83 The purposes of this pull request are: - Update the implementation of sparse EKI to make it compatible with the new version of DataContainer. Co-authored-by: Jinlong <[email protected]> Co-authored-by: Jinlong <[email protected]>
|
bors r+ |
119: Address issue #113 r=ilopezgp a=jinlong83 The purposes of this pull request are: - Update the implementation of sparse EKI to make it compatible with the new version of DataContainer. Co-authored-by: Jinlong <[email protected]> Co-authored-by: Jinlong <[email protected]>
|
bors r- |
|
Canceled. |
|
I don't think you need to merge from master, just squash. Bors makes sure everything is ok before merging if there are no conflicts |
updated the implementation with function sparse_eki_update. minor change of format. minor change of comments. minor change of comments.
|
bors r+ |
|
Build succeeded: |
The purposes of this pull request are: