Add UQ parameter reading / writing functionality #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces dependencies on CLIMAParameters and TOML.
|
Awesome, thanks @bielim
|
odunbar
requested changes
May 18, 2022
Co-authored-by: Charles Kawczynski <[email protected]>
added 2 commits
May 18, 2022 16:49
- Turn `file_parsing_uq.jl` into module `UQParameters.jl` - Remove `CLIMAParameters.jl` dependency - Fix some indentations and other minor cosmetic issues
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 23, 2022
162: Add UQ parameter reading / writing functionality r=bielim a=bielim This code adds the module `UQParameters.jl`, which provides functionality for reading UQ parameters from `.toml` files and writing them back to `.toml` files. It also allows for convenient writing of EKP parameter ensembles. The code used to live in `CLIMAParameters` but was moved here due to its dependency on `EnsembleKalmanProcesses.jl`. The discussion on whether or not the use of `eval` should be permitted has been postponed to a potential future PR. `eval` is currently not used in the code due to the security leak it introduces, but its use would make the code in its current form as well as its maintenance in the future considerably simpler. Co-authored-by: Melanie <[email protected]> Co-authored-by: bielim <[email protected]>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code adds the module
UQParameters.jl, which provides functionality for reading UQ parameters from.tomlfiles and writing them back to.tomlfiles. It also allows for convenient writing of EKP parameter ensembles. The code used to live inCLIMAParametersbut was moved here due to its dependency onEnsembleKalmanProcesses.jl.The discussion on whether or not the use of
evalshould be permitted has been postponed to a potential future PR.evalis currently not used in the code due to the security leak it introduces, but its use would make the code in its current form as well as its maintenance in the future considerably simpler.