add N_ens input to Unscented, it can be N+2 or 2N+1 #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilopezgp
reviewed
May 28, 2022
ilopezgp
approved these changes
Jul 2, 2022
There was a problem hiding this comment.
LGTM, thanks @Zhengyu-Huang !! Can you squash commits before merging? Here is how to do it just in case.
format revert format revert update format update sigma points update tests format format format
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add an argument for Unscented struct and its constructor
The number of sigma points (ensemble size) N_ens can be = 2N+1 or N+2
In its constructor, the default value is 2N+1