Include expected warning text in @test_logs #176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Purpose and Content
Purpose
Change use of
@test_logs
to allow unit tests to pass when dependencies raise deprecation warnings. The writeup in issue #175 makes the case that the solution implemented here is the best way to deal with the case where the deprecation warning is raised in code we don't control.Content
For all uses of
@test_logs
in unit tests,match_mode=:any
, to allow the test to pass when deprecation errors are raised.Benefits and Risks
Benefits
Unit test suite now passes without needing to wait for the deprecations in Distributions.jl to be fixed in a new release;
Risks
If other, "serious" warnings are raised in addition to the warning being tested for, this implementation will give a false negative. As discussed in issue #175, as far as I know there's no way to optionally filter out deprecation warnings only.
Linked Issues
PR Checklist