Add localization documentation. #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilopezgp
force-pushed
the
loc_doc
branch
2 times, most recently
from
33ea980
to
ee6f0b6
Compare
|
@eviatarbach let me know what you think of the docs so far, perhaps we can expand on it with the result from a few examples on a subsequent PR? |
|
Hi Ignacio, Looks good to me! I was thinking I could add a little information about the idea behind SEC, but I could do that with a separate PR. |
eviatarbach
approved these changes
Aug 23, 2022
That is a good idea! Let's do it in a separate PR. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 24, 2022
189: Add localization documentation. r=ilopezgp a=ilopezgp # PULL REQUEST ## Purpose and Content - Document localization kernels. Co-authored-by: Ignacio <[email protected]>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Purpose and Content