ParameterDistributions.jl improvements #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odunbar
changed the title
odunbar
force-pushed
the
orad/param-dist-improvements
branch
from
1d6d426
to
c7e329e
Compare
ilopezgp
reviewed
Aug 28, 2022
odunbar
force-pushed
the
orad/param-dist-improvements
branch
3 times, most recently
from
41388b8
to
96483ac
Compare
…ethod, with unit tests tests all now pass misc update to DataContainers test clima format removed MvNormal deprecated calls new climaformatter codecov parameters->bounds and API for Constraint docs API format rebase typo format
odunbar
force-pushed
the
orad/param-dist-improvements
branch
from
9e6420c
to
36f8057
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #184 and #192, also small update to remove warning in DataContainers/ParameterDistributions test. This works towards a better interface for ParameterDistributions.
Content
constrained_gaussianto multidimensional distirbutions by adding arepeats=Nkeyword withN=1default.NoConstraintBoundedBelowBoundedAboveandBoundedx = bounded_below(3.0)storesx.parameters = Dict("lower_bound" => 3.0)==to Constraints (based on the aboveparametersandTypes, as constraints are functions so hard to equate)==to ParameterDistributions for easier testing callsMvNormal(int,real)calls that are now deprecated, replacing withMvN(zeros(int), real*I)