Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error messaging #209

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Improved error messaging #209

merged 1 commit into from
Sep 22, 2022

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Sep 21, 2022

Purpose

Closes #199, and improved error messaging.

Content

  • Adds information such as "Expected X, got Y " where applicable into the error messages
  • Changes error( and ErrorException to better errors where required.
  • Improves codecov for error messages
  • Also, adds a one-character bugfix (\!!! info -> !!! info) in a docs page, updated version here (not worth a separate PR)

improved error message information, of what was passed to cause the error

string() -> "$()"

format

single \ bugfix in docs

ekp->uki

improved error message code-cov

removed impossible-to-reach error branch

climaformat

string() -> $()
Copy link
Contributor

@ilopezgp ilopezgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odunbar
Copy link
Collaborator Author

odunbar commented Sep 22, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 22, 2022

Build succeeded:

@bors bors bot merged commit f5aa524 into main Sep 22, 2022
@bors bors bot deleted the orad/error-message branch September 22, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update error message
2 participants