Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating and checking EKP examples #213

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Updating and checking EKP examples #213

merged 1 commit into from
Sep 29, 2022

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Sep 28, 2022 •
edited
Loading

Purpose

To run through all current EKP examples, checking they run, checking whether manifests could be updated, and applying our new code-styles and interfaces.

Content

Checked and updated examples and docs for:

  • Loss Minimization
  • Loss Minimization Sparse
  • Lorenz (EKI/UKI/distributed) - actually uses priors with transformations, and produces gifs rather than pngs - per - iteration.
  • Localization
  • Cloudy(EKI/UKI) - also now produces gifs rather than displaying pngs
  • AerosolActivation - produces PDFs, and CloudyMicrophysics version is pinned to v0.5
  • ClimateMachine - updated priors

@odunbar odunbar force-pushed the orad/update-examples-notations branch 2 times, most recently from ea6b008 to 41d54b8 Compare September 28, 2022 18:25
@odunbar odunbar force-pushed the orad/update-examples-notations branch 2 times, most recently from efda2b6 to 4da3e93 Compare September 28, 2022 20:50
ilopezgp
ilopezgp approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@ilopezgp ilopezgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the changes!

docs/src/examples/Cloudy_example.md Outdated Show resolved Hide resolved
docs/src/examples/lorenz_example.md Outdated Show resolved Hide resolved
examples/AerosolActivation/aerosol_activation.jl Outdated Show resolved Hide resolved
examples/AerosolActivation/aerosol_activation.jl Outdated Show resolved Hide resolved
examples/Cloudy/Cloudy_example_uki.jl Outdated Show resolved Hide resolved
examples/Lorenz/Lorenz_example_ukp.jl Outdated Show resolved Hide resolved
@odunbar
updated prior constructors
abdc879 
typo

Lorenz models now have correct getters and produce gifs

sparse example uses new getters

example uses new priors/getters

updated cloudy examples, also now produce gifs

reduce priors to speed convergence for UKI

update aerosol activation and pin version

format

update priors climatemachine

example docs update

phi getter

updated literated examples

addressed comments, and removed additional commented lines
@odunbar odunbar force-pushed the orad/update-examples-notations branch from cdc9e0b to abdc879 Compare September 29, 2022 00:06
@odunbar
Copy link
Collaborator Author

odunbar commented Sep 29, 2022

bors r+

@odunbar odunbar changed the title [WIP] updating and checking EKP examples Updating and checking EKP examples Sep 29, 2022
@bors
Copy link
Contributor

bors bot commented Sep 29, 2022

Build succeeded:

@bors bors bot merged commit a581a64 into main Sep 29, 2022
@bors bors bot deleted the orad/update-examples-notations branch September 29, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilopezgp ilopezgp ilopezgp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odunbar @ilopezgp