-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add documentation for ensemble Kalman sampler #22
Conversation
I had a look at the Oceaninanigans docs raw files and they use double The full line equations can be done with either Links:
Regarding notation, if you could come to consensus between yourself and @ilopezgp, I am happy to pitch in here too, I would argue for consistency with the EKI/CES papers, as these will be the go-to references and I believe are self consistent |
Hi Melanie - You need to add your doc page into the "Ensemble Kalman Sampler" => "ensemble_kalman_sampler.md" into the dictionary |
Done, thank you! |
Hi Melanie, some comments as i see them - some similarities with Ignacios EKI PR:
|
Hi Melanie - this looks great, notation is unified with Ignacios as far as i can see! Some typos:
|
I adopted the notation in Cleary et al., where capital
Fixed, thanks!
Fixed, thanks!
I left it in there because personally I like it when people are explicit about the packages that are used to run the code. The |
LGTM! Merge away |
bors r+ |
Build succeeded: |
This PR adds documentation for the ensemble Kalman sampler and fills a part of the documentation needs identified in #15.
Notes: