Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert to stable ICs for constrained_gaussian solver #224

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Revert to stable ICs for constrained_gaussian solver #224

merged 1 commit into from
Oct 21, 2022

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Oct 21, 2022

Purpose

Closes #223
Note the optimization appears more robust now for no loss of accuracy (according to our unit testing)

Content

  • Set ICs in unconstrained space to (0,1) rather than trying to get a more intelligent approximation
  • removed tests for IC function

@odunbar
Copy link
Collaborator Author

odunbar commented Oct 21, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 21, 2022

Build succeeded:

@bors bors bot merged commit 51f15f8 into main Oct 21, 2022
@bors bors bot deleted the orad/IC_const_gaus branch October 21, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajjadazimi sajjadazimi sajjadazimi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fancy initial conditions break, resort to basic Initial conditions
2 participants
@odunbar @sajjadazimi