Adding sinusoid example #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild succeeded: |
odunbar
reviewed
Nov 7, 2022
There was a problem hiding this comment.
Looks like a great start!
I have made a few stylistic comments but there are a couple of substance too: Mainly there are 3 things to do
- replace
get_u_finalwithget_\phi_final(see my comment). - Add sections "setting up the problem" and "applying the algorithm" as a lot of the code here is just setup
- Could you add 2 gifs of this example to the index page? One showing the collapse in the constrained parameter-parameter space, and another showing the model ensembles. 1 frame = 1 iteration. I don't think much setup is required here, just a title saying "learning the amplitude and shift of a sine curve"
Thank you!
odunbar
reviewed
Nov 15, 2022
eviatarbach
force-pushed
the
sinusoid
branch
from
d1cf67c
to
f40942f
Compare
odunbar
approved these changes
Nov 15, 2022
|
Yes, what should we do about this? Mention it? I think reducing the observation error would make it converge even faster, which makes the animation less interesting. |
eviatarbach
force-pushed
the
sinusoid
branch
from
f40942f
to
3f86781
Compare
eviatarbach
force-pushed
the
sinusoid
branch
from
3f86781
to
9ebf66b
Compare
|
bors r+ |
|
Build succeeded: |
This was referenced Nov 18, 2022
Closed
bors bot
added a commit
that referenced
this pull request
Nov 21, 2022
235: Sinusoid example in paper.md r=odunbar a=odunbar <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Adds the sinusoid example #228 into the paper ## Content <!--- specific tasks that are currently complete - Solution implemented --> Latest pdf: [paper.pdf](https://github.com/CliMA/EnsembleKalmanProcesses.jl/files/10061313/paper.pdf) <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [x] I have read and checked the items on the review checklist. Co-authored-by: odunbar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #183