-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add State-of-Field, and rearranges paper.md sections #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilopezgp
reviewed
Nov 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @odunbar . I added some edits below, feel free to use them partially if you prefer a different phrasing.
odunbar
force-pushed
the
orad/joss-update-1
branch
3 times, most recently
from
November 15, 2022 23:24
01001a3
to
37aece0
Compare
ilopezgp
approved these changes
Nov 17, 2022
odunbar
force-pushed
the
orad/joss-update-1
branch
from
November 17, 2022 19:51
2fddb65
to
d44546b
Compare
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 17, 2022
231: Orad/joss update 1 r=odunbar a=odunbar <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Latest paper version [paper.pdf](https://github.com/CliMA/EnsembleKalmanProcesses.jl/files/10016815/paper.pdf) ## Content <!--- specific tasks that are currently complete - Solution implemented --> - Add sentence to introduction on docs landing page - Add state of the field RE julia packages into `paper.md` - Move statement of need above "features" in `paper.md` <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [x] I have read and checked the items on the review checklist. Co-authored-by: odunbar <[email protected]>
bors r- |
Canceled. |
draft comparison to other tools paper.md ilopezgp comments texttt on EKP added kalman method packages refined statement, added ref typo small edit typo Update paper.md Co-authored-by: Ignacio Lopez-Gomez <[email protected]> add pdf
odunbar
force-pushed
the
orad/joss-update-1
branch
from
November 17, 2022 20:04
c0d4780
to
c1949a2
Compare
bors r+ |
Build succeeded: |
Closed
odunbar
changed the title
Orad/joss update 1
Add State-of-Field, and rearranges paper.md sections
Nov 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Latest paper version
paper.pdf
Content
paper.md
paper.md