Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add State-of-Field, and rearranges paper.md sections #231

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Nov 10, 2022

Purpose

Latest paper version
paper.pdf

Content

  • Add sentence to introduction on docs landing page
  • Add state of the field RE julia packages into paper.md
  • Move statement of need above "features" in paper.md

  • I have read and checked the items on the review checklist.

Copy link
Contributor

@ilopezgp ilopezgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @odunbar . I added some edits below, feel free to use them partially if you prefer a different phrasing.

docs/src/index.md Outdated Show resolved Hide resolved
paper.md Outdated Show resolved Hide resolved
paper.md Outdated Show resolved Hide resolved
paper.md Outdated Show resolved Hide resolved
@odunbar odunbar force-pushed the orad/joss-update-1 branch 3 times, most recently from 01001a3 to 37aece0 Compare November 15, 2022 23:24
paper.md Outdated Show resolved Hide resolved
@odunbar
Copy link
Collaborator Author

odunbar commented Nov 17, 2022

bors r+

bors bot added a commit that referenced this pull request Nov 17, 2022
231: Orad/joss update 1 r=odunbar a=odunbar

<!--- THESE LINES ARE COMMENTED -->
## Purpose 
<!--- One sentence to describe the purpose of this PR, refer to any linked issues:
#14 -- this will link to issue 14
Closes #2 -- this will automatically close issue 2 on PR merge
-->
Latest paper version 
[paper.pdf](https://github.com/CliMA/EnsembleKalmanProcesses.jl/files/10016815/paper.pdf)


## Content
<!---  specific tasks that are currently complete 
- Solution implemented
-->
- Add sentence to introduction on docs landing page
- Add state of the field RE julia packages into `paper.md`
- Move statement of need above "features" in `paper.md`

<!---
Review checklist

I have:
- followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/
- followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/
- followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy
- checked that this PR does not duplicate an open PR.

In the Content, I have included 
- relevant unit tests, and integration tests, 
- appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

-->

----
- [x] I have read and checked the items on the review checklist.


Co-authored-by: odunbar <[email protected]>
@odunbar
Copy link
Collaborator Author

odunbar commented Nov 17, 2022

bors r-

@bors
Copy link
Contributor

bors bot commented Nov 17, 2022

Canceled.

draft comparison to other tools

paper.md

ilopezgp comments

texttt on EKP

added kalman method packages

refined statement, added ref

typo

small edit

typo

Update paper.md

Co-authored-by: Ignacio Lopez-Gomez <[email protected]>

add pdf
@odunbar
Copy link
Collaborator Author

odunbar commented Nov 17, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 17, 2022

Build succeeded:

@bors bors bot merged commit 9c4c13e into main Nov 17, 2022
@bors bors bot deleted the orad/joss-update-1 branch November 17, 2022 20:16
@odunbar odunbar mentioned this pull request Nov 18, 2022
@odunbar odunbar changed the title Orad/joss update 1 Add State-of-Field, and rearranges paper.md sections Nov 21, 2022
@odunbar odunbar mentioned this pull request Nov 28, 2022
@odunbar
Copy link
Collaborator Author

odunbar commented Nov 28, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants