Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update bibtex and paper #242

Merged
merged 1 commit into from
Dec 4, 2022
Merged

update bibtex and paper #242

merged 1 commit into from
Dec 4, 2022

Conversation

jbytecode
Copy link
Contributor

Due to the JOSS submission: openjournals/joss-reviews#4869 (comment)

  • Correct bibtex (capitalization, etc.)
  • Add missing references
  • Correct paper

@jbytecode jbytecode mentioned this pull request Dec 4, 2022
Closed
@ilopezgp ilopezgp self-requested a review December 4, 2022 23:18
ilopezgp
ilopezgp approved these changes Dec 4, 2022
View reviewed changes
Copy link
Contributor

@ilopezgp ilopezgp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ilopezgp
Copy link
Contributor

ilopezgp commented Dec 4, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 4, 2022

Build succeeded:

@bors bors bot merged commit 0bd24ce into CliMA:main Dec 4, 2022
@odunbar
Copy link
Collaborator

odunbar commented Dec 5, 2022

Thanks for the comments LGTM too. Cheers for review & merge @ilopezgp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilopezgp ilopezgp ilopezgp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbytecode @ilopezgp @odunbar