Some typo fixes, and paragraph shortening. #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ilopezgp
commented
Dec 5, 2022
•
ilopezgp
commented
- Fixes several typos of the manuscript submission to JOSS: [REVIEW]: EnsembleKalmanProcesses.jl: Derivative-free ensemble-based model calibration openjournals/joss-reviews#4869,
- Adds missing reference,
- Shortens section without modifying content,
- Updates pdf.
ilopezgp
force-pushed
the
fixes_final_manuscript
branch
from
cd47943
to
4e7e6ec
Compare
odunbar
approved these changes
Dec 5, 2022
| @@ -37,6 +37,20 @@ @article{julia | |||
| journal = {{SIAM} Review} | |||
| } | |||
|
|
|||
| @inproceedings{ge2018t, | |||
There was a problem hiding this comment.
is there a doi for this? or is this biburl going to work the same?
There was a problem hiding this comment.
I checked and they do not have a doi, unfortunately. Just the URL, which should be "permanent" to some extent
|
bors r+ |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.