Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dict-based transforms #249

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Add dict-based transforms #249

merged 1 commit into from
Feb 3, 2023

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Jan 26, 2023 •
edited
Loading

Purpose

Closes #248 , by providing convenience methods to deal with the results of get_distribution(Samples(...))

Content

  • add new transform_unconstrained_to_constrained for dicts
  • add new transform_constrained_to_unconstrained for dicts
  • add get_all_constraints with return_dict flag
  • add Samples-based ParameterDistribution constructor from AbstractMatrix input
  • add unit tests
  • I have read and checked the items on the review checklist.

@odunbar odunbar changed the title [WIP] add dict-based u->c and c->u, also add dict-based get_all_constraints [WIP] add dict-based transforms Jan 26, 2023
@odunbar odunbar force-pushed the orad/transform-dict branch 2 times, most recently from 89f3893 to bb69fd0 Compare January 30, 2023 21:53
@odunbar
add dict-based u->c and c->u, also add dict-based get_all_constraints
923fbbc 
update ParameterDistributions and tests

get_all_constraints unit test

unit test

format;

codecov

format
@odunbar odunbar requested a review from ilopezgp January 31, 2023 02:03
@odunbar odunbar changed the title [WIP] add dict-based transforms Add dict-based transforms Jan 31, 2023
@odunbar
Copy link
Collaborator Author

odunbar commented Feb 3, 2023

bors r+

@odunbar
Copy link
Collaborator Author

odunbar commented Feb 3, 2023

merging, as this simply adds functionality and tests, and is compatible with current interface.

@bors
Copy link
Contributor

bors bot commented Feb 3, 2023

Build succeeded:

@bors bors bot merged commit 26306e5 into main Feb 3, 2023
@bors bors bot deleted the orad/transform-dict branch February 3, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilopezgp ilopezgp Awaiting requested review from ilopezgp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transforming samples requires application to dicts
1 participant
@odunbar