Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_mean() for PDs, fix installation docs #29

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Fix get_mean() for PDs, fix installation docs #29

merged 1 commit into from
Jun 3, 2021

Conversation

ilopezgp
Copy link
Contributor

The current output of get_mean(ParameterDistribution) is an Array{FT, 2} that cannot be used as an input to the Sampler(). I did not see any instance of the code where this structure was useful, so I have changed the function to return an Array{FT, 1}.

Note that this change simplifies every single use of get_mean(ParameterDistribution) in the tests and examples.

Apart from this, I have corrected the installation guide.

@ilopezgp ilopezgp requested review from bielim and odunbar May 22, 2021 20:22
@odunbar
Copy link
Collaborator

odunbar commented Jun 2, 2021

We store samples as oriented 2D arrays, viewed as lists of columns e.g if you have samples of data they are always stored as columns, I expect this was the mindset as to why the mean should be a column. However as the statistics mean function naturally reduces the dimension, it is definitely sensible to store it as a Vector{FT} and I believe we do also this for other "means" in the code too.

so LGTM

@ilopezgp
Copy link
Contributor Author

ilopezgp commented Jun 3, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 3, 2021

Build succeeded:

@bors bors bot merged commit dbd5dd5 into main Jun 3, 2021
@bors bors bot deleted the il/fix_eks branch June 3, 2021 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants