Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to select termination time for DataMisfitController #291

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Jun 7, 2023

Purpose

Closes #290

Content

  • Added a keyword argument terminate_at for DMC
  • Added tests to show it stops at the correct time
  • Added a line into the docs

  • I have read and checked the items on the review checklist.

@odunbar odunbar requested a review from eviatarbach June 7, 2023 13:54
@eviatarbach
Copy link
Contributor

LGTM! Thanks!

@odunbar
Copy link
Collaborator Author

odunbar commented Jun 8, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 8, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 7e64a5e into main Jun 8, 2023
11 checks passed
@bors bors bot deleted the orad/DMCstop branch June 8, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We can improve DMC consistency by controlling the termination tolerance
2 participants