Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add == for schedulers #298

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Add == for schedulers #298

merged 1 commit into from
Jun 13, 2023

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Jun 13, 2023

Purpose

Closes #297

Content

  • add overload to Base.(==) for LearningRateSchedulers
  • add tests

  • I have read and checked the items on the review checklist.

Copy link
Contributor

@eviatarbach eviatarbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@odunbar
Copy link
Collaborator Author

odunbar commented Jun 13, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 13, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit deb0e8e into main Jun 13, 2023
11 checks passed
@bors bors bot deleted the orad/equality-schedulers branch June 13, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataMisfitController() == DataMisfitController() gives false
2 participants