Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Lorenz 96 example #31

Merged
merged 10 commits into from
Aug 4, 2021
Merged

Add documentation for Lorenz 96 example #31

merged 10 commits into from
Aug 4, 2021

Conversation

mhowlan3
Copy link
Contributor

No description provided.

@mhowlan3 mhowlan3 requested a review from odunbar May 28, 2021 22:42
@odunbar
Copy link
Collaborator

odunbar commented Jun 4, 2021

Hi Mike,

Can you add the new Make.jl file so the docs compile online. Also you seem to have a few extra jld2 files

@mhowlan3 mhowlan3 changed the title [WIP] Add documentation for Lorenz 96 example Add documentation for Lorenz 96 example Jun 17, 2021
@odunbar
Copy link
Collaborator

odunbar commented Jul 28, 2021

Sorry it took me so long: Comments as I see them:

  1. Overview - describe what the example does. E.g here is L96 with additional periodic-in-time forcing, we try to determine parameters (Amplitude and stationary component) from some [define which] statistics.
  2. L96 - Characteristic time = Lyapunov time?
  3. L96 - mention that we need to stay within the chaotic regime for F?
  4. Dynamic - could you define the defaults as you do in the next sections
  5. Priors, "wide" is defined with respect to the L96 variability? It may not be wide if one prescribes a high obs noise

Otherwise this looks great! Thanks Mike - it is very clear and nicely partitioned!

@mhowlan3
Copy link
Contributor Author

mhowlan3 commented Aug 4, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 4, 2021

Build succeeded:

@bors bors bot merged commit 5d3d539 into main Aug 4, 2021
@bors bors bot deleted the mh/L96-docs branch August 4, 2021 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants