Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused history field in DataMisfitController #312

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

eviatarbach
Copy link
Contributor

The history field in DataMisfitController no longer does anything. It should be removed.

@eviatarbach eviatarbach requested a review from odunbar July 7, 2023 22:55
Copy link
Collaborator

@odunbar odunbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think we were wondering about a redundancy of information storage, but happy to remove until needed!

@eviatarbach
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 11, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit b349ff3 into main Jul 11, 2023
13 checks passed
@bors bors bot deleted the eviatarbach-patch-1 branch July 11, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants